chore(ci): linting job changes regarding goheader#116
Merged
Conversation
- golangci-lint runs as configured in .golangci.yml - goheader runs separately on new issues only
3 tasks
qdm12
changed the title
Collaborator
|
Why is this necessary? What is it about |
Author
|
So this only enables goheader in that CI step, so that it runs on new changes.
|
ARR4N
approved these changes
Feb 4, 2025
Collaborator
ARR4N
left a comment
ARR4N
left a comment
There was a problem hiding this comment.
Thanks for the clarification. I've modified the PR description because I don't think it captured the rationale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
goheaderonly needs to be run on files changed in the current PR as it will otherwise suggest updating copyright years on untouched files. The other linters, however, should be run in the same manner as a local invocation.(this was thought about in #115)
How this works
How this was tested
Linting CI passing